-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max weighted matching #107
base: master
Are you sure you want to change the base?
Conversation
You can easily visualize (small) graphs with the following code
though I'm not sure |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 77.2% 77.75% +0.54%
==========================================
Files 33 33
Lines 2338 2400 +62
Branches 376 391 +15
==========================================
+ Hits 1805 1866 +61
+ Misses 408 407 -1
- Partials 125 127 +2
Continue to review full report at Codecov.
|
If I find the time, I'm interesting in adding the symmetric best matching and stable matching methods from Franke et. al as well. These methods seem to produce comparable results, for a much lower computational cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this well written Pull Request. A few change requests and remarks below.
Thanks @jpweytjens
That would be nice to have in the documentation or on the examples page. If it turns out to be a succes, we add it to the toolkit. Documentation: https://recordlinkage.readthedocs.io/en/latest/ref-classifiers.html?highlight=onetoone#network |
I've added a new commit that should address all the requested changes.
I'm curious to hear your thoughts on this new version. If you're happy with them, I would like to add a test for the |
Can you review the changes @J535D165 ? |
This pull request implements max weighted bipartite graph matching as a method for the
OneToOne
class. It usesnetworkx
for the actual matching algorithm. Multiple helper functions are defined to transform theMultiIndex
output fromrecordlinkage
to agraph
object and back.