-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hera files for spack-stack-1.9.0 #1507
Conversation
cdo: | ||
externals: | ||
- spec: [email protected] | ||
prefix: /apps/cdo/2.3.0/gnu_13.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failure for cdo
is odd:
checking whether /contrib/spack-stack/spack-stack-1.9.0-release/spack/lib/spack/env/oneapi/icpx supports C++20 features with -std:c++20... no
configure: error: *** A compiler with support for C++20 language features is required.
given that spack
sets:
export SPACK_CXX=/apps/oneapi/compiler/2024.2/bin/icpx
and
% /apps/oneapi/compiler/2024.2/bin/icx --version
Intel(R) oneAPI DPC++/C++ Compiler 2024.2.1 (2024.2.1.20240711)
and similar configurations (e.g. hercules, orion, ursa) don't exhibit this failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected. The GNU backend for oneapi is gcc 9.1 or 9.2 I believe on Hera, and that only supports C++17. See configs/common/packages.yaml
section cdo
. You can force an older version of cdo
being built on Hera in Hera's packages.yaml (i.e. for all compilers used on Hera).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configs/sites/tier1/hera/compilers.yaml
for the PR specs gcc/13.2.0
and pathing for that version:
environment:
prepend_path:
PATH: '/apps/gnu/gcc-13.2.0/bin'
LD_LIBRARY_PATH: '/apps/gnu/gcc-13.2.0/lib64'
CPATH: '/apps/gnu/gcc-13.2.0/include'
Wouldn't that be enough to find an appropriate backend?
One could also add
cdo:
require::
- '%gcc'
to configs/sites/tier1/hera/packages.yaml
, or is that not a preferable alternative?
The system-provided module that's referenced here was built with gcc/13.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I would just try an older version of cdo and be done with it.
The Ubuntu CI GNU error is because of spack/spack#48971 and is resolved with #1500 for develop. Can you try to cherry-pick this commit, please? 58ab975 |
I'll try this when we get Hera back. |
Summary
Update yaml files for Hera for release/1.9.0
Testing
Installed GNU and oneAPI on Hera
Systems affected
Hera
Issue(s) addressed
Solves part of issue #1485
Checklist