Slight overhaul to enhance readability, safety, and consistency #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added formatting functions for consistent user-status output. - Moved all pre-deploy resources to beginning of process to break early if any are unavailable. - Added extra status messages from script for time-consuming steps. - Added user option to avoid re-copying SSH keys in home. - Moved all temporary deployment files to a temporary directory. - No longer permanently modify local SSH config to disable host key checking. - Removed redundant ipAddressPool deployment which may fail. - Fixed issue where user-specified Kube-VIP option was ignored.
|
Thank you for taking the time to do this, I will test it. |
* Slightly simplified longhorn-K3S script for node selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made several changes to the
k3s.shscript to augment its existing capabilities. As the commit message attests, there are several modifications as well as a couple bug fixes. Primarily among these:$HOMEthat are not strictly required. Whether they arecurlfile downloads or other artifacts produced by the script, all have been relocated to a temporary directory.I could have gone further, but this was meant to be a minimally invasive modification. Future changes should likely include status checks for each of the important commands so there's an exit on error, rather than assuming all steps have succeeded.