-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow switching spaces through menu and status bar icons #37
Open
ruittenb
wants to merge
142
commits into
Jaysce:main
Choose a base branch
from
ruittenb:development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a memory leak. CGSCopyManagedDisplaySpaces returns an unmanaged object reference, so we need to retain it to ensure it's properly cleaned up.
…space numbers from showing on the menubar display
# Conflicts: # Spaceman/Helpers/SpaceObserver.swift
…current-monitor' into development
- configuration for keyboard shortcuts - desktop switcher
ruittenb
force-pushed
the
development
branch
from
September 19, 2024 19:53
b5b077c
to
8cd20c0
Compare
ruittenb
force-pushed
the
development
branch
from
September 25, 2024 10:41
9a24542
to
db521c8
Compare
Also, distinguish LMB and other events
ruittenb
force-pushed
the
development
branch
from
September 25, 2024 16:55
db0ea63
to
c0cd1cc
Compare
ruittenb
changed the title
Feature: allow switching spaces
Feature: allow switching spaces through menu and status bar icons
Sep 25, 2024
ruittenb
force-pushed
the
development
branch
from
September 25, 2024 20:55
698c433
to
fc2cc7f
Compare
How complicated is it to build and try out this branch locally? I looked for a CONTRIBUTING file or build instructions but didn't see it. |
Hello @wsmoak , you can clone the repository at https://github.com/ruittenb/Spaceman and check out either the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to switch between spaces.
This has been implemented using AppleScript in combination with shortcut keys defined for Mission Control.
This addresses #7 (click icons)
#38 (display names without numbers)
Also merged fix from #27 (memory leak)
Also merged feature #32 (feat: Only show active spaces)
Also added feature #10 (>3 characters in space names)