Setup plugin testing and publication #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # kotlinx.fuzz.gradle/build.gradle.kts
FerrumBrain
reviewed
Jan 17, 2025
| @Test | ||
| fun test() { | ||
| // for now, just checking that all dependencies resolve | ||
| val kfuzzer: KFuzzer = KFuzzerImpl(byteArrayOf(1)) |
There was a problem hiding this comment.
It seems like my mistake, I believe that KFuzzerImpl should be internal, but I may be wrong
FerrumBrain
reviewed
Jan 17, 2025
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
|
|
||
| // TODO: kotlin.test requires a class with empty ctor, NOT an object. Will this be a problem? |
There was a problem hiding this comment.
It can be solved in two ways:
- By removing
@Testannotation, we don't need it by design, therefore an actual user will be able to useobjectinstead ofclass - By adding dependency on
junit-platform-engineand using ```
tasks.test {
useJUnitPlatform()
}
However I am not sure that it won't break anything, since we use our own engine. But still it helps in replacing `class` with `object`
FerrumBrain
reviewed
Jan 17, 2025
| } | ||
|
|
||
| group = "org.plan.research" // TODO: org.jetbrains.research(.plan) ? |
There was a problem hiding this comment.
- I am getting
java.lang.NullPointerException: group.displayName must not be nullwhen building. It doesn't affect anything but it is a little bit annoying, so if you could fix it, it would be wonderful - We have
GROUP_IDconstant inversions.ktyou may consider looking at it. - We have
groupset in theorg.plan.research.kotlinx-fuzz-module.gradle.ktswhy should we change it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we can test our plugin without local publication! (which I set up, spending many hours debugging a single misplaced dot 💀, which we don't need in the end ☠️)