Added separate sensor to pass along raw robotStatus property to HA #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohNan
approved these changes
Oct 5, 2024
|
Very nice way of making it flexible for tinkerers and also keeping the HA format. Thanks! Will monitor it and try to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a separate sensor for the raw robotState of the robot vacuums.
It is based on feedback here and here. The issue is that the robotState is more expressive (e.g., returning or charging as part of a pitstop, to continue cleaning) than the states defined for the Vacuum Entity class in HA. By also exposing the robotState as a separate sensor for the device, one allows for more advanced automation possibilities.
I thought the added sensor was a cleaner option than expanding the Vacuum entity states with non-standard states for that entity class. I also opted to pass the numeric state along without trying to translate it to a string to keep implementation more straightforward and also (hopefully) allow, e.g., the new "Hygienic 700" robot vacuum to use the same code when eventually someone tries to use the get this into HA using the integration.