Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix purea9 #72

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Fix purea9 #72

merged 5 commits into from
Jan 28, 2024

Conversation

hermanops
Copy link
Contributor

I've added the FRESH360 filter and could you take a look at my fix for CO2? Is my assumption correct?

This is (part of) my JSON:

{
  "applianceData": {
    "applianceName": "Air purifier",
    "created": "2024-01-21T17:20:10.4936149Z",
    "modelName": "PUREA9",
  },
  "properties": {
    "reported": {
      "ErrPM2_5": False,
      "ErrTVOC": False,
      "ErrTempHumidity": False,
      "ErrFanMtr": False,
      "ErrCommSensorDisplayBrd": False,
      "DoorOpen": False,
      "FilterLife": 92,
      "Workmode": "Auto",
      "Fanspeed": 3,
      "UILight": False,
      "SafetyLock": False,
      "Ionizer": True,
      "FilterType": 100,
      "DspIcoPM2_5": True,
      "DspIcoPM1": True,
      "DspIcoPM10": True,
      "DspIcoTVOC": True,
      "logE": 3103,
      "logW": 2150,
      "RSSI": -63,
      "TVOC": 28,
      "PM1": 10,
      "PM2_5": 13,
      "PM10": 16,
      "Temp": 21,
      "Humidity": 46,
    }
  }
}

debug logs show I have:
"FilterType": 100

which according to the APP is FRESH360
I think this should be adjusted, as the A9 doesn't return CO2. It does show ECO2 in the json.
@hermanops
Copy link
Contributor Author

@JohNan : could you take a look at this PR?

@JohNan
Copy link
Owner

JohNan commented Jan 27, 2024

Sorry, I completely forgot to look at your PR. I'm on it now!

Copy link
Owner

@JohNan JohNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just one minor change.

custom_components/wellbeing/api.py Outdated Show resolved Hide resolved
after review from JohNan
@hermanops hermanops requested a review from JohNan January 27, 2024 18:49
Copy link
Owner

@JohNan JohNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but you also have to remove it from A7 or else you get duplicates.

@hermanops hermanops requested a review from JohNan January 27, 2024 21:17
Copy link
Owner

@JohNan JohNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JohNan JohNan merged commit 09c995f into JohNan:main Jan 28, 2024
2 checks passed
@hermanops hermanops deleted the fix-PUREA9 branch January 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants