-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix purea9 #72
Fix purea9 #72
Conversation
debug logs show I have: "FilterType": 100 which according to the APP is FRESH360
I think this should be adjusted, as the A9 doesn't return CO2. It does show ECO2 in the json.
@JohNan : could you take a look at this PR? |
Sorry, I completely forgot to look at your PR. I'm on it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just one minor change.
after review from JohNan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but you also have to remove it from A7 or else you get duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I've added the FRESH360 filter and could you take a look at my fix for CO2? Is my assumption correct?
This is (part of) my JSON: