Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable try and catch for the play button observer #23

Closed
wants to merge 6 commits into from

Conversation

JohnyP36
Copy link
Owner

@JohnyP36 JohnyP36 commented Nov 4, 2023

Any additions, changes or removals is at the Authors discretion.
You're free to counterargue (to a certain point) if you disagree with the decision.
To avoid being banned, don't constantly re-open or create new (related) issue reports or pull requests.

Prerequisites

  • I've read the Code of Conduct and the Contributing Guidelines
  • This is more than one or two issue(s)
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • Other webextensions related to Youtube are disabled
    • using a new, unmodified browser profile
  • I am running the latest version of the extension

Describe the issue

See #22 : extension seems to keep reloading by certain users Google/YT blocks using and Adblocker.

Browser & Extension version

Browser name & version Extension Version Operating System
`Firefox 119` `2.0.9.2` `Windows 10, 22H2`

Notes

Basically reverts halve of 4e76d40.

Disadvantage: if the extension couldn't find the play button if will simply stop working and you have to manually reload the webpage.

Basically reverts halve of 4e76d40. 

Disadvantage: if the extension couldn't find the play button if will simply stop working and you have to manually reload the webpage.
Basically reverts halve of c5c06d7. 

Disadvantage: if the extension couldn't find the play button if will simply stop working and you have to manually reload the webpage.
@JohnyP36 JohnyP36 marked this pull request as ready for review November 4, 2023 08:38
@JohnyP36 JohnyP36 linked an issue Nov 4, 2023 that may be closed by this pull request
5 tasks
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions bot added the stale This issue or pull request is stale label Dec 18, 2023
@github-actions github-actions bot removed the stale This issue or pull request is stale label Jan 6, 2024
@JohnyP36 JohnyP36 added bug Something isn't working can't reproduce I can't reproduce this issue labels Jan 9, 2024
@JohnyP36
Copy link
Owner Author

JohnyP36 commented Jan 9, 2024

As per issue #22 Constant Reloading After Ublock/Google Changes to Ads, I can't reproduce this issue.
Although in the newest version of this extension in the Firefox Add-ons this "problem" got patched, I will not change it in the core code on this repo - as explained earlier.

@JohnyP36 JohnyP36 closed this Jan 9, 2024
@JohnyP36 JohnyP36 deleted the JohnyP36-fix-reloading branch January 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce I can't reproduce this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant Reloading After Ublock/Google Changes to Ads
1 participant