Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: staged payment e2e tests #4076

Merged
merged 2 commits into from
Feb 6, 2025
Merged

test: staged payment e2e tests #4076

merged 2 commits into from
Feb 6, 2025

Conversation

olgapod
Copy link
Contributor

@olgapod olgapod commented Jan 10, 2025

Description

This MR adds some initial e2e test suit for the Staged Payment motion.

Test cases included in the PR:

  1. Staged payment with
    • Permission decision method
    • Staking decision method
    • Reputation decision method
  2. Form validation
  3. Milestones table interactions (duplicate/delete entries)

Testing

Step 1. Spin up the dev env and seed the test data

npm run dev followed by node scripts/create-data.js --yes

Step 2. Build and start the frontend in preview mode

npm run preview

Step 3. Run the tests in a separate terminal

npm run e2e staged-payment

Step 4. The tests should pass ( if any failures - please send me .zip files from /playwright-report/data directory)

@olgapod olgapod self-assigned this Jan 10, 2025
@olgapod olgapod force-pushed the e2e/staged-payment branch from 882f99f to f44af7b Compare January 20, 2025 16:24
@olgapod olgapod force-pushed the e2e/staged-payment branch from f44af7b to f470025 Compare January 29, 2025 07:59
@olgapod olgapod force-pushed the e2e/staged-payment branch from f470025 to 02daba8 Compare January 29, 2025 18:36
@olgapod olgapod marked this pull request as ready for review January 29, 2025 18:49
@olgapod olgapod requested a review from a team as a code owner January 29, 2025 18:49
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work here! 💯

My runs are all failing on the "Decision Method" step though

image

Here is the attached playwright report https://drive.google.com/file/d/1a2oybRWb_u-FmA3AYcZP7DSkwzniovG1/view?usp=drive_link

@olgapod olgapod requested a review from rdig February 4, 2025 07:39
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases look sensible, and I've got a full pass. Very nice work @olgapod! 💯

image image

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Very nice!

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job putting these together, all passing without issue for me!

Screenshot 2025-02-05 at 11 49 56

@olgapod olgapod merged commit 2c31f1d into master Feb 6, 2025
2 checks passed
@olgapod olgapod deleted the e2e/staged-payment branch February 6, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants