-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ensure minimum dimension of 120x120px for file uploads #4163
Conversation
99d39bd
to
7fd6876
Compare
Hey @rumzledz - There are a few other areas this PR needs to address, as the 250x250 dimension was used globally across all image uploads. The following sections need to be updated to ensure consistency with a single dimension for all image touchpoints and across all responsive sizes. 1. Profile page in the User Account section: ![]() ![]() 2. Edit Colony action - change Colony logo modal ![]() |
Hey @melyndav ! Thanks for visiting this PR 😄 I can confirm that I have updated those areas as well. It is now a minimum of 120x120px across the board 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO the size check works as expected, but one thing I noticed is that the "Remove" button doesn't work.
I can "Change" the image, but cannot remove it to get back to the original blockie
Screencast.from.2025-01-24.14-16-51.mp4
7fd6876
to
4b2e775
Compare
4b2e775
to
f6dcaa5
Compare
f6dcaa5
to
37e5fe5
Compare
@rdig I was eventually able to understand the issue you found about not being able to remove the avatar. it turned out to be a master bug that didn't have a reason to make itself known... until now 🐞 I've pushed the changes, hopefully that's the last of that! |
37e5fe5
to
3852524
Compare
3852524
to
9a72828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, I can remove the image without issue:
https://github.com/user-attachments/assets/95f4ea1c-5bd6-4b71-803d-e63a3e4b023f
And to confirm, it is created with the blockie:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now, all good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rumzledz nice work on this issue! 🎉
The right error message is shown if the dimensions are not 120x120px
for the token, the colony and the profile avatar image upload
Screen.Recording.2025-01-29.at.10.12.04.mov
Screen.Recording.2025-01-29.at.10.12.40.mov
Screen.Recording.2025-01-29.at.10.14.03.mov
However @rumzledz I did notice on the avatar image upload, once I remove the file with which I wanted to replace it due to it not respecting the dimensions, the current avatar was replaced with a blockie. Is this as intended? If so, I'll happily approve your PR 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the bug related to removing an image from the uploader replacing the existing image with a blockie will be treated in a separate issue. Nice work @rumzledz 🥇
Description
As discussed with Product, files being uploaded should have a dimension of at least 120x120px.
Testing
Pika
Resolves #3858