Fix (?) intermittent error in create-data script

[area]

In #4150, I saw @mmioana had experienced one of my most hated things while trying to run the create-data script: an intermittent error

so I went hunting and think I've arrived at a simple fix.

Currently, when the script is run:

• Colonies get between 1 and 100 million of a token
• Domains get between 100 and 500 of a token

So far, so good.

Individual users are then paid out from each domain by calling userPayments with the three walletUsers (which are the first three ganache accounts) and a random contributor address.

Users are paid out a random amount between 1 and 3 tokens... unless we are considering the first 'ganache' address, which gets 50 tokens, a fixed amount.

So, how does this result in a (rare) error when running the script? When paying out from a domain, the random contributor selected can be the first ganache address (if the domain is not the first in the colony to be considered). In that case, we will pay out to the first ganache address twice, resuling in somewhere between 102 and 106 tokens trying to leave the domain - but there is a chance that the domain only received as low as 100 tokens, and will not have enough to pay out.

In that scenario, the transaction will fail with the overflow message seen in the original error - but to occur, the domain must have received a sufficiently low number of tokens (less than 1% chance) and the first ganache account must have been randomly selected as a contributor (haven't properly understood how this is generated, but must be less than 33%), explaining why it is so rare to occur, anecdotally.

To fix the issue, the 'constant' amount we pay out to the first ganache address has been reduced to 30 tokens, which means that the most we can pay out from a domain is 66 tokens, which is less than the smallest amount that can be given to a domain.

For anyone paying particularly close attention, the last non-error log in the screenshot was paying out address 0x27fF0C145E191C22C75cD123C679C3e1F58a4469, which is ganacheAccounts[2], not ganacheAccounts[0]. However, the log occurs in the script after the payout succeeds, and so the error will have occurred when paying out the next address, which you can see in the failed transaction blob is 0xb77D57F4959eAfA0339424b83FcFaf9c15407461, as would be the case in the situation I've described here.

I've checked with Raul and this 50 tokens isn't a magic value anywhere, so shouldn't break anything. Obviously the issue with an intermittent error is that it's tough to be sure that it's fixed, especially one with such a low recurrence rate, but I hope that the above case is compelling.

If/when this is merged, if you see a similar error in the future, please let me know - I really detest intermittent errors, which make it incredibly hard to debug actual issues, and try to extinguish them with extreme prejudice!

[rdig]

Very nice @area 💯

[rdig]

Nicely done Alex! This will alleviate that spotty error that we were seeing!

Thank you for your contribution!

[iamsamgibbs]

Nice investigation! Tested just to be safe and script passes as expected and everything is still working.

[mmioana]

Awesome @area thanks so much for investigating and fixing this issue 🤩