Fix: changing distribution type should show accurate percentage #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassgeta
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Nice job, this stuff was pretty pesky, nicely ironed out 💯
- Created the classic "let's make .33333333333 decimals" payments
- Changing to unequal leaves everything intact
A bug I've found (which probably makes no sense fixing here), but if we add values beyond the 4th decimal, it will allow creating the action
but since we round to 4 decimals, the end result is correct
kinda confusing 🤔
anyhow, this doesn't affect this PR so I'll gladly smash approve 🚢
mmioana
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Really nice work on this one @davecreaser 💯
Tested it and seems the values do add up to 100% when switching from equal to unequal distribution type
Screen.Recording.2025-01-30.at.14.02.50.mov
Nice!
Comment on lines
+67
to
+83
| export const getUnevenSplitPaymentTotalPercentage = ( | ||
| amount: number, | ||
| recipients: SplitPaymentRecipientsFieldModel[], | ||
| ) => { | ||
| if (!amount) { | ||
| return 0; | ||
| } | ||
|
|
||
| const total = | ||
| recipients?.reduce((acc, recipient) => { | ||
| return acc + Number(recipient.amount); | ||
| }, 0) || 0; | ||
|
|
||
| const percentage = (100 * total) / amount; | ||
|
|
||
| return Number(percentage.toFixed(4)); | ||
| }; |
rdig
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
equal(which will always be 100%) to unequal suddenly makes the percentage not 100%.Testing
Diffs
Changes 🏗
Resolves #3856