Fix: Extension notifications should show the username when using metatransactions #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsamgibbs
force-pushed
the
fix/3913-extension-transactions-should-use-correct-creator
branch
from
ffa7dc4 to
2928bcd
Compare
bassgeta
previously approved these changes
Jan 31, 2025
mmioana
previously approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Really nice work @iamsamgibbs 🎉
Now the notifications properly show the username when using metatransactions 💯
Enabled metatransactions
Installed the extension, deprecated it, uninstalled it, installed it again and changed the threshold
And all notifications contained the username 💯
davecreaser
previously approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Nice one @iamsamgibbs thanks for fixing this 📈
Notifications and the extension page correctly show Leela now:
iamsamgibbs
dismissed stale reviews from davecreaser, mmioana, and bassgeta
via
a9df1c5
iamsamgibbs
force-pushed
the
fix/3913-extension-transactions-should-use-correct-creator
branch
from
2928bcd to
a9df1c5
Compare
iamsamgibbs
force-pushed
the
fix/3913-extension-transactions-should-use-correct-creator
branch
from
a9df1c5 to
ae66f6d
Compare
davecreaser
approved these changes
Feb 4, 2025
bassgeta
approved these changes
Feb 4, 2025
mmioana
approved these changes
Feb 4, 2025
iamsamgibbs
deleted the
fix/3913-extension-transactions-should-use-correct-creator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See block-ingestor PR
This PR makes a change to how the
creatorname is set for extension related actions.Previously the block-ingestor used
receipt.fromas the creator for all extension related actions as the extension event does not emit the msg_sender. This works fine when metatransactions are disabled, but when they are enabled the metatransaction address in place of the original creator.This PR adds a new
getTransactionSignerAddressfunction to the block-ingestor (courtesy of @bassgeta 's implementation on the proxy colony PRs!) and replaces uses ofreceipt.fromto get the address of the user who actually installed the extension.This means the correct user now shows in both notifications and the extension details.
Warning
If anyone knows of a reason why replacing the metatransactions address with the user address is a bad idea, please let me know!
Testing
npm run dev --notificationsDiffs
New stuff ✨
getTransactionSignerAddressfunction addedChanges 🏗
receipt.fromreplaced withgetTransactionSignerAddressResolves #3913