fix: remove default recipient address for correct advanced payments validation #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsamgibbs
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The oneliner fix for Advanced Payment validation. When you upload CSV with an empty recipient address, our app sets a default address, and we can submit a form with default address. We want to show an error in case if recipient field is empty in CSV file.
Testing
Step 1. Download CSV:
expenditures_batch.14.csv
Step 2. Open Advanced Payments
Step 3. Upload file
Step 4. Submit form and verify that you can see an error "Recipient is required"
Resolves #3964