fix: make expandatures stakes finalizable in UserHub menu

[Nortsova]

Description

Expenditure stakes weren't shown as "Finalizable" in the User Hub menu.

Thanks to @jakubcolony for pair-programing this with me. 🙌

Note

Block-ingestor PR for this: JoinColony/block-ingestor#330

Testing

1. Install the Voting Reputation extension
2. Create Advanced Payments with the "Staking" decision method
3. Verify that the stake appears in User Hub:

4. Press "Confirm details" -> Press "Fund" -> Select "Reputation" -> Fund payment 5. Fully support and fully oppose voting 6. Verify that there is a second stake in User Hub

7. Vote for "Support" and Reveal your vote
8. Verify that second stake got "Finalizable" status

9. Finalize it and check User Hub again. Status should be "Claimable"
10. Release with "Reputation"
11. Fully support and fully oppose voting
12. Verify that there is a new Stake in the User Hub

13. Vote for "Support" and Reveal your vote
14. Verify that third stake got "Finalizable" status

15. Finalize it and check User Hub again. Status should be "Claimable"

16. Verify that dates for all stakes are the same

Resolves #4047

[iamsamgibbs]

Nice job working through this, seems like everything is working nicely! Checking the stake type rather than simply looking for an expenditureId feels a lot more robust.

Created a staking payment. Funded with reputation and got it to a finalizable stage:

And progressed it to a claimable state:

Then went through releasing with reputation:

The only thing I noticed is that the release motion doesn't get the correct description here:

It's kind of unrelated to the issue, but I'm not sure if you could fix it up here? Otherwise we can just make a new issue for it.

[Nortsova]

Thank you, @iamsamgibbs. Nice catch on the translation. I will handle it at #4143 🙌

[davecreaser]

Very nice @Nortsova changes all look good and it works as expected (thanks also for the super clear testing steps! 🚀)

[rdig]

Nicely done here!