Skip to content

Commit

Permalink
Merge pull request #133 from xGamingDudex/patch-1
Browse files Browse the repository at this point in the history
Fix FFMPEGDownloader to download using HTTPS. 
Thanks for this fix. 
The maintainer of 0110.be is me ;) it is expected to stay up for a while. 
There is a trade-off between providing binaries for each platform in the jar file (which makes it rather large) or downloading them only when needed and only for the platform. Currently I am still in favor of option two since many probably do not need decoding.

Adding binaries to a github repo is perhaps not a bad idea, then they can be updated and versioned easily. If i update an ffmpeg static binary it could have some less desired consequences.

Thanks again.
  • Loading branch information
JorenSix authored Oct 24, 2017
2 parents 2d590d6 + c3310d5 commit c26e500
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/be/tarsos/dsp/util/FFMPEGDownloader.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
public class FFMPEGDownloader {

private static String url = "http://0110.be/releases/TarsosDSP/TarsosDSP-static-ffmpeg/";
private static String url = "https://0110.be/releases/TarsosDSP/TarsosDSP-static-ffmpeg/";

private final String ffmpegBinary;

Expand Down

0 comments on commit c26e500

Please sign in to comment.