-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CatBoostClassifier/CatBoostRegressor Docs & Fix badge links #20
Conversation
@ablaom The MLJTestInterface tests are failing because the data is being split down the middle, so only one label is being passed to the |
Ah. Thanks for reporting this. Ideally, binary classifiers should be able to handle a level not manifest in the training target (but present in the pool) but I understand this can be a pain to fix. One could predict the seen class every time, with probabability one, if probabilistic (and skip the call to fit the core model). Although this ordinarily isn't a problem on larger datasets, I would encourage you to post an issue to have this remedied at some point. In the meantime one could either mark the test as broken (probably better practice) or hack a fix as you suggest. Some other models failed in this way and we fixed them a little while back. CatBoost slipped through on the old version of the tests (not sure why) but the even stricter tests just released are catching the issue. By the way, I tested that the stricter tests are okay for all registered models, so am inclined to keep the new stricter tests, as I still believe they are correct. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 73.61% 77.57% +3.95%
==========================================
Files 6 6
Lines 163 165 +2
==========================================
+ Hits 120 128 +8
+ Misses 43 37 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I just added a temporary fix to ensure the tests work across the platforms. Setting the test to broken didn't fully fix it, so I assume the Python Exception is breaking the model fit, and not being caught. Here is the test table when setting the test to broken.
|
Perhaps @ericphanson will want to comment / review. I've looked over the PR and it looks otherwise good, thanks. In any case, I suggest posting an issue to revert the test when #22 is addressed, or you can add a comment there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
I think a real maintainer should merge this. @ericphanson or @tylerjthomas9 ? |
I don't have merge permissions. However, this still looks good to me. I am struggling to think of a good way to implement the single class case for the classifier (#22), but that can be tackled later. |
Sounds like this was included in #23. Thanks both! |
I added documentation for the python CatBoostClassifier/CatBoostRegressor models. Additionally, the beacon-biosignals links were updated with JuliaAI, so hopefully, all the badges will work again.
#19