Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for training classifiers with one class present #29

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Add support for training classifiers with one class present #29

merged 6 commits into from
Jan 11, 2024

Conversation

tylerjthomas9
Copy link
Collaborator

Ref: #22

Should we have a warning when there is only one class?

Changes in this PR

  • New fit, predict functions for CatBoostClassifier to handle the case when only one class is present.
  • Bumped Aqua.jl version and added missing Compat entries
  • Bumped actions and codecov in CI

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e7f56b7) 77.10% compared to head (b323d46) 75.55%.

Files Patch % Lines
src/mlj_catboostclassifier.jl 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   77.10%   75.55%   -1.56%     
==========================================
  Files           6        6              
  Lines         166      180      +14     
==========================================
+ Hits          128      136       +8     
- Misses         38       44       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -52,10 +52,6 @@
for data in [MLJTestInterface.make_binary(), MLJTestInterface.make_multiclass()]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of orthogonal, but FYI, to test row-based tables as well as column-based ones, we can now do this (with MLJTestInterface.jl 0.2.4):

Suggested change
for data in [MLJTestInterface.make_binary(), MLJTestInterface.make_multiclass()]
for data in [
MLJTestInterface.make_binary(),
MLJTestInterface.make_multiclass(),
MLJTestInterface.make_binary(row_table=true),
MLJTestInterface.make_multiclass(row_table=false),
]

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tylerjthomas9 tylerjthomas9 merged commit 6d6ff0f into JuliaAI:main Jan 11, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants