-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for training classifiers with one class present #29
Add support for training classifiers with one class present #29
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 77.10% 75.55% -1.56%
==========================================
Files 6 6
Lines 166 180 +14
==========================================
+ Hits 128 136 +8
- Misses 38 44 +6 ☔ View full report in Codecov by Sentry. |
test/mlj_interface.jl
Outdated
@@ -52,10 +52,6 @@ | |||
for data in [MLJTestInterface.make_binary(), MLJTestInterface.make_multiclass()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of orthogonal, but FYI, to test row-based tables as well as column-based ones, we can now do this (with MLJTestInterface.jl 0.2.4):
for data in [MLJTestInterface.make_binary(), MLJTestInterface.make_multiclass()] | |
for data in [ | |
MLJTestInterface.make_binary(), | |
MLJTestInterface.make_multiclass(), | |
MLJTestInterface.make_binary(row_table=true), | |
MLJTestInterface.make_multiclass(row_table=false), | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Ref: #22
Should we have a warning when there is only one class?
Changes in this PR