-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding use_ajax
flag to MLFlow
instances
#44
Conversation
Are there any other MLFlow implementations/deployments using Wouldn't a more natural API be to provide the API base url, e.g. |
I don't know if there's other than DagsHub. I consider the API base URL approach as a good one. With that, we don't need to be aware of if it's an Need opinions about this decision. |
I agree with the base URL approach, but it will break compatibility for existing users. I.e. they will need to update their URLs if we make that change and they upgrade to a newer release of the package. |
No objections but this definitely needs to be tagged breaking. So if we have any other breaking changes in mind... |
I'm very excited about this PR! I was about to open a new PR myself, as the latest version is broken for us (past ones work). The following commit broke the ability to work with Databricks: e27ac10 We use Databricks-managed MLFlow and we need the "HOST/api/2.0" format rather than the current "/ajax-api" one. The proposed approach to provide the base URL including the relevant API path would work great for us! |
A very much related breaking change would be to change the type of |
@pebeto Would it be, please, possible to merge this PR and tag a new version? Given that the commit linked above was breaking (anything above v0.4.4), anyone who updates (even if having compat to "0.4") might get the same error as we did. It would be good to have a clean new tag. |
@pebeto Would you please consider merging the PR to have a working minor version release? The bug introduced in 0.4.5 (the ajax in path) still persists. |
275316a
to
66a9359
Compare
Alowing compatibility with both
REST
andAJAX
endpoints.