Skip to content

Commit

Permalink
removing model field bypass and now adding it into the performance ev…
Browse files Browse the repository at this point in the history
…aluation report
  • Loading branch information
pebeto committed Aug 7, 2023
1 parent 0596799 commit a86babf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion src/resampling.jl
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ function Base.show(io::IO, ::MIME"text/plain", e::PerformanceEvaluation)
"with these fields:")
println(io, " measure, operation, measurement, per_fold,\n"*
" per_observation, fitted_params_per_fold,\n"*
" report_per_fold, train_test_rows")
" report_per_fold, train_test_rows", "model")
println(io, "Extract:")
show_color = MLJBase.SHOW_COLOR[]
color_off()
Expand Down
3 changes: 0 additions & 3 deletions test/resampling.jl
Original file line number Diff line number Diff line change
Expand Up @@ -794,9 +794,6 @@ end
print(show_text)
docstring_text = string(@doc(PerformanceEvaluation))
for fieldname in fieldnames(PerformanceEvaluation)
if fieldname == :model
continue
end
@test contains(show_text, string(fieldname))
# string(text::Markdown.MD) converts `-` list items to `*`.
@test contains(docstring_text, " * `$fieldname`")
Expand Down

0 comments on commit a86babf

Please sign in to comment.