Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing args in docstring of metadata_model #150

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Fix missing args in docstring of metadata_model #150

merged 2 commits into from
Jul 1, 2022

Conversation

rikhuijzer
Copy link
Member

No description provided.

@ablaom
Copy link
Member

ablaom commented Jun 29, 2022

Removing docstring from the document string (sic) was intentional, as implementers should just give a doc-string in the usual way now. The docstring trait remains but is now computed rather than overloaded. In JuliaAI/MLJ.jl#913 we are working to remove overloadings from implementations.

It would be appropriate to have metadata_model throw a depwarn if this kwarg is specified and put in the next patch.

Good catch with the human_name.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #150 (9c1bf7c) into dev (536dd72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #150   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files           8        8           
  Lines         326      326           
=======================================
  Hits          290      290           
  Misses         36       36           
Impacted Files Coverage Δ
src/metadata_utils.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536dd72...9c1bf7c. Read the comment docs.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that.

@ablaom ablaom merged commit eca57b1 into JuliaAI:dev Jul 1, 2022
@ablaom ablaom mentioned this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants