Fix accidental piracy in BufferedVector

JuliaData · May 17, 2024 · 8ee21d4 · 8ee21d4
1 parent f9e11b7
commit 8ee21d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/BufferedVectors.jl b/src/BufferedVectors.jl
@@ -29,7 +29,7 @@ Base.IteratorSize(::BufferedVector) = Base.HasLength()
 Base.IteratorEltype(::BufferedVector) = Base.HasEltype()
 Base.collect(x::BufferedVector{T}) where {T} = length(x) > 0 ? @inbounds(x.elements[1:length(x)]) : T[]
 Base.eltype(::BufferedVector{T}) where T = T
-@inline Base.push!(buffer::T, x::S) where {T,S} = push!(buffer, convert(T, x))
+@inline Base.push!(buffer::BufferedVector{T}, x::S) where {T,S} = push!(buffer, convert(T, x))
 @inline function Base.push!(buffer::BufferedVector{T}, x::T) where {T}
     if length(buffer.elements) == buffer.occupied
         Base._growend!(buffer.elements, _grow_by(T))

diff --git a/test/BufferedVectors.jl b/test/BufferedVectors.jl
@@ -51,6 +51,11 @@ using SentinelArrays: BufferedVectors
     skip_element!(bv)
     @test length(bv) == 2
 
+    empty!(bv)
+    push!(bv, 2.0) # convert
+    @test bv == [2]
+    @assert length(bv) == 1
+
     bv = BufferedVector{Int}()
     push!(bv, 1)
     @test length(bv.elements) == BufferedVectors._grow_by(Int)