Add TypedSyntax package #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package attempts to map statements in type-inferred code back to the source code as written by the programmer. The intention is to use this in Cthulhu to present the results of inference in an easier-to-digest form. There are, of course, potential additional applications of this source-mapping, which is why it is developed as a semi-independent package.
This also elides Core.Const more systematically
|
Nice, one can run the TypedSyntax tests as part of CI even before Cthulhu knows about this package. Makes sense, but still nice. |
timholy
commented
Feb 28, 2023
aviatesk
reviewed
Mar 1, 2023
Co-authored-by: Shuhei Kadowaki <[email protected]>
This substantial refactor handles types and pre/post "wrapping" (in parenthesis) from the caller rather than the callee. This more precisely wraps type annotations.
aviatesk
approved these changes
Mar 2, 2023
|
I added It's starting to feel decent, though future changes are a certainty. Unless there are objections, I'll merge and register later today. |
vchuravy
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package attempts to map statements in type-inferred code back to the source code as written by the programmer.
The intention is to use this in Cthulhu to present the results of inference in an easier-to-digest form. There are, of course, potential additional applications of this source-mapping, which is why it is developed as a semi-independent package.
This is part of #345, split out so it can be registered before making Cthulhu dependent on it.