Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect array type in wrong-mode pushforward/pullback #620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 10, 2024

DI source

  • In pushforward/pullback, give x/y as a first argument to the map over cartesian indices. This allows array types (e.g. static or GPU) to be preserved.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (9a524d3) to head (7c97dd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   97.71%   92.85%   -4.87%     
==========================================
  Files         112      110       -2     
  Lines        5522     5511      -11     
==========================================
- Hits         5396     5117     -279     
- Misses        126      394     +268     
Flag Coverage Δ
DI 96.65% <100.00%> (-2.30%) ⬇️
DIT 85.55% <ø> (-9.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as draft November 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant