Remove unnecessary steps in tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 2 2
Lines 371 371
=======================================
Hits 333 333
Misses 38 38 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the test DICOM files do not contain a preamble, i.e.128 bytes + "DCIM". This was inconvenient in the testset for
dcmdir_parse()because the function expects all files to contain a preamble.The old solution was to delete the two problematic files prior to testing
dcmdir_parse(). This is no longer necessary because of PR #65 which automatically skips the problematic files.The current PR cleans up the unnecessary steps in the tests.