This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Add metadata tags to azure_policy_definition #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenanwarren
approved these changes
Jun 4, 2021
kenanwarren
reviewed
Jun 4, 2021
| * including arrays and objects. JupiterOne requires tags of type `string | number | boolean`, | ||
| * so this filters out incompatible properties. | ||
| */ | ||
| function getCompatibleTagProperties(metadata: { [s: string]: any }) { |
There was a problem hiding this comment.
We could also stringify the properties that didn't meet that criteria.
There was a problem hiding this comment.
Ah good thought! I opened this to track and implement later: #382
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375