Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Int 4181 ingest azure frontdoor entities #515

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

ndowmon
Copy link
Contributor

@ndowmon ndowmon commented Jun 14, 2022

Added

  • Added azure_frontdoor entities

@ndowmon ndowmon requested a review from a team as a code owner June 14, 2022 19:30
@zemberdotnet
Copy link
Contributor

Thanks for updating the SDK dependencies and tests. I was actually trying to do some mass upgrades and changes for the new "graph:dependencies": "j1-integration visualize-dependencies" command and ran into errors from the tests.

If you want you can add the command to the package.json, or it will get added later when I push it out to all the critical ones.

Copy link
Contributor

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉

@@ -363,7 +363,7 @@ describe('iterateTables', () => {
developerId: 'ndowmon1',
};

test('all', async () => {
test.skip('all', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? If so, can you please create a ticket with a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndowmon ndowmon merged commit 4ab8f81 into main Jun 14, 2022
@ndowmon ndowmon deleted the int-4181-ingest-azure-frontdoor-entities branch June 14, 2022 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants