This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
INT-4147 - Iterating KMS project locations switched to hardcoded list #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change KMS key ring client request code to iterate hardcoded list of project locations instead of hitting the KMS project location API. The KMS project location API was being hammered and could cause API quota issues.
austinkelleher
force-pushed
the
INT-4147-gcp-locations-api
branch
from
197ceba to
3f4a9f6
Compare
ndowmon
reviewed
Jun 13, 2022
| // Fetched directly from the `projects.locations.list` KMS API | ||
| // | ||
| // See: https://cloud.google.com/kms/docs/locations#regional | ||
| export const KMS_SERVICE_LOCATIONS: string[] = [ |
There was a problem hiding this comment.
todo: Add a CI test to ensure that the locations returned from projects.locations.list match this list of locations. This would help us to keep this list up-to-date.
ndowmon
previously approved these changes
Jun 13, 2022
ndowmon
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change KMS key ring client request code to iterate hardcoded list of project
locations instead of hitting the KMS project location API. The KMS project
location API was being hammered and could cause API quota issues.