Gcp enhancement milestone1 #657
Conversation
…de-Deploy Gcp enhancement milestone1 code deploy
…loyDB Gcp enhancement milestone1 alloy db
…oud-Spanner Gcp enhancement milestone3 cloud spanner
Gcp enhancement milestone1 dev
CHANGELOG.md
Outdated
| @@ -1,8 +1,64 @@ | |||
| # v3.4.0 (Tue Apr 28 2024) | |||
|
|
|||
| ### Added | |||
There was a problem hiding this comment.
Readme is updated automatically, no need to update this manually.
There was a problem hiding this comment.
Removed the added content.
src/steps/alloydb/constants.ts
Outdated
| description: 'AlloyDB for Postgre SQL Connection.', | ||
| defaultsToDisabled: false, | ||
| }, | ||
| [IngestionSources.PROJECT_HAS_ALLOYDB_SERVICE_RELATIONSHIP]: { |
There was a problem hiding this comment.
We usually don't include to ingest sources relationships steps, we include ingestion steps only
There was a problem hiding this comment.
Removed from all relationships.
src/steps/alloydb/converter.ts
Outdated
| }; | ||
| return createGoogleCloudIntegrationEntity(data, { | ||
| entityData: { | ||
| source: {}, |
There was a problem hiding this comment.
add data to the source
| @@ -0,0 +1,80 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
There was a problem hiding this comment.
We can remove snaps. We don't longer use them
There was a problem hiding this comment.
Removed all snapshot files.
| ingestionSourceId: IngestionSources.ALLOYDB_POSTGRE_SQL_BACKUP, | ||
| name: 'fetch-alloydb-postgre-sql-backup', | ||
| entities: [ | ||
| { |
There was a problem hiding this comment.
With the new approaches, we usually create constants to declare entities and relationships.
There was a problem hiding this comment.
Followed the new approach for all the new steps.
| entities: [], | ||
| relationships: [ | ||
| { | ||
| _type: RELATIONSHIP_TYPE_CLOUD_DEPLOY_SERVICE_HAS_DELIVERY_PIPELINE, |
| name: 'Cloud Deploy Automation', | ||
| entities: [ | ||
| { | ||
| resourceName: 'Cloud Deploy Automation', |
| relationships: [ | ||
| { | ||
| _class: RelationshipClass.HAS, | ||
| _type: RELATIONSHIP_TYPE_COMPUTE_NETWORK_HAS_ROUTER, |
| name: 'Compute Router', | ||
| entities: [ | ||
| { | ||
| resourceName: 'Cloud Compute Router', |
src/steps/kms/converters.test.ts
Outdated
| test('should convert to entity', () => { | ||
| expect( | ||
| createKmsCryptoKeyEntity({ | ||
| cryptoKey: getMockKmsCryptoKey(), | ||
| location: 'us', | ||
| projectId: 'j1-gc-integration-dev-v2', | ||
| projectId: 'j1-gc-integration-dev-v3', |
There was a problem hiding this comment.
Why was this updated? We do have the matchRequestById in the recordings
Services:
Cloud Spanner
Code Deploy
Cloud Router
AlloyDB for PostgreSQL
Miro Board Link:
https://miro.com/app/board/uXjVNrblgf8=/