This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
INT-4161 - Add Property Fields to Rapid7 Findings #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDubber
reviewed
Jan 6, 2023
| @@ -23,7 +23,7 @@ | |||
| "type-check": "tsc", | |||
| "test": "jest", | |||
| "test:env": "LOAD_ENV=1 yarn test", | |||
| "test:no-tls-verify": "NODE_TLS_REJECT_UNAUTHORIZED=0 && yarn test", | |||
| "test:no-tls-verify": "NODE_TLS_REJECT_UNAUTHORIZED=0 yarn test", | |||
VDubber
reviewed
Feb 14, 2023
src/client.ts
Outdated
| } | ||
| return rec; | ||
| } else { | ||
| return 'No recommendation available'; |
VDubber
reviewed
Feb 14, 2023
src/client.ts
Outdated
| const references = | ||
| refs?.page?.totalResources > 0 | ||
| ? refs.resources.map((r) => r.advisory?.href).join('\n') | ||
| : 'No references available'; |
There was a problem hiding this comment.
undefined is preferred over No references available
VDubber
reviewed
Feb 14, 2023
src/client.ts
Outdated
| const impact = | ||
| exploits?.page?.totalResources > 0 | ||
| ? exploits.resources.map((r) => r.title || '').join('\n') | ||
| : 'No impact information available'; |
There was a problem hiding this comment.
undefined is preferred over No impact ...
VDubber
reviewed
Feb 14, 2023
src/client.ts
Outdated
| : 'No impact information available'; | ||
| const references = | ||
| refs?.page?.totalResources > 0 | ||
| ? refs.resources.map((r) => r.advisory?.href).join('\n') |
There was a problem hiding this comment.
Instead of joining the hrefs, please map to an array of strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
impact,recommendations, andreferencestoinsightvm_findingChanged
insightvm_findingandinsightvm_vulnerability'snameproperty touse
vulnerability.titlefrom the API response