Skip to content

Commit

Permalink
Ashwin (#431)
Browse files Browse the repository at this point in the history
* enhancements

* enhancements

* added default secret key

* added default secret key

* added default secret key

* added default secret key

* code formatting
  • Loading branch information
KingCSharp committed Feb 21, 2021
1 parent ccb8346 commit d0e6e2b
Show file tree
Hide file tree
Showing 14 changed files with 623 additions and 710 deletions.
2 changes: 1 addition & 1 deletion accounts/api_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -625,4 +625,4 @@ def delete(self, request, pk, format=None):
"error": True,
"errors": "You don't have permission to delete this Attachment",
}
)
)
13 changes: 5 additions & 8 deletions accounts/swagger_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,14 @@
account_detail_get_params = [
company_params_in_header,
openapi.Parameter(
"account_attachment", openapi.IN_QUERY, type=openapi.TYPE_FILE,
),
openapi.Parameter(
"comment", openapi.IN_QUERY, type=openapi.TYPE_STRING
"account_attachment",
openapi.IN_QUERY,
type=openapi.TYPE_FILE,
),
openapi.Parameter("comment", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]

account_comment_edit_params = [
company_params_in_header,
openapi.Parameter(
"comment", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter("comment", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]

270 changes: 119 additions & 151 deletions cases/api_views.py

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion cases/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ class Case(models.Model):
choices=CASE_TYPE, max_length=255, blank=True, null=True, default=""
)
account = models.ForeignKey(
Account, on_delete=models.CASCADE, blank=True, null=True, related_name="accounts_cases",
Account,
on_delete=models.CASCADE,
blank=True,
null=True,
related_name="accounts_cases",
)
contacts = models.ManyToManyField(Contact)
# closed_on = models.DateTimeField()
Expand Down
23 changes: 10 additions & 13 deletions cases/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class Meta:
"created_on_arrow",
)


class CaseCreateSerializer(serializers.ModelSerializer):
closed_on = serializers.DateField

Expand All @@ -47,20 +48,16 @@ def __init__(self, *args, **kwargs):

def validate_name(self, name):
if self.instance:
if Case.objects.filter(
name__iexact=name, company=self.company
).exclude(id=self.instance.id).exists():
raise serializers.ValidationError(
"Case already exists with this name"
)
if (
Case.objects.filter(name__iexact=name, company=self.company)
.exclude(id=self.instance.id)
.exists()
):
raise serializers.ValidationError("Case already exists with this name")

else:
if Case.objects.filter(
name__iexact=name, company=self.company
).exists():
raise serializers.ValidationError(
"Case already exists with this name"
)
if Case.objects.filter(name__iexact=name, company=self.company).exists():
raise serializers.ValidationError("Case already exists with this name")
return name

class Meta:
Expand All @@ -76,4 +73,4 @@ class Meta:
"account",
"company",
"created_on_arrow",
)
)
65 changes: 23 additions & 42 deletions cases/swagger_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,20 @@

cases_list_get_params = [
company_params_in_header,
openapi.Parameter(
"name", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"status", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"priority", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"account", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter("name", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("status", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("priority", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("account", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]

cases_detail_get_params = [
company_params_in_header,
openapi.Parameter(
"case_attachment", openapi.IN_QUERY, type=openapi.TYPE_FILE,
),
openapi.Parameter(
"comment", openapi.IN_QUERY, type=openapi.TYPE_STRING
"case_attachment",
openapi.IN_QUERY,
type=openapi.TYPE_FILE,
),
openapi.Parameter("comment", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]

cases_delete_params = [
Expand All @@ -45,38 +37,27 @@
openapi.Parameter(
"priority", openapi.IN_QUERY, type=openapi.TYPE_STRING, required=True
),
openapi.Parameter("type_of_case", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter(
"type_of_case", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"closed_on", openapi.IN_QUERY,
type=openapi.TYPE_STRING,
format="date",
required=True
"closed_on",
openapi.IN_QUERY,
type=openapi.TYPE_STRING,
format="date",
required=True,
),
openapi.Parameter("teams", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("assigned_to", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("account", openapi.IN_QUERY, type=openapi.TYPE_INTEGER),
openapi.Parameter(
"teams", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"assigned_to", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"account", openapi.IN_QUERY, type=openapi.TYPE_INTEGER
),
openapi.Parameter(
"case_attachment", openapi.IN_QUERY, type=openapi.TYPE_FILE,
),
openapi.Parameter(
"contacts", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter(
"description", openapi.IN_QUERY, type=openapi.TYPE_STRING
"case_attachment",
openapi.IN_QUERY,
type=openapi.TYPE_FILE,
),
openapi.Parameter("contacts", openapi.IN_QUERY, type=openapi.TYPE_STRING),
openapi.Parameter("description", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]

cases_comment_edit_params = [
company_params_in_header,
openapi.Parameter(
"comment", openapi.IN_QUERY, type=openapi.TYPE_STRING
),
openapi.Parameter("comment", openapi.IN_QUERY, type=openapi.TYPE_STRING),
]
7 changes: 5 additions & 2 deletions crm/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
load_dotenv(dotenv_path=env_path)

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = os.getenv("SECRET_KEY", '&q1&ftrxho9lrzm$$%6!cplb5ac957-9y@t@17u(3yqqb#9xl%')
SECRET_KEY = os.getenv(
"SECRET_KEY", "&q1&ftrxho9lrzm$$%6!cplb5ac957-9y@t@17u(3yqqb#9xl%"
)


# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = os.getenv("DEBUG")
Expand Down Expand Up @@ -54,7 +57,7 @@
"drf_yasg",
"corsheaders",
"django_ses",
"django_blog_it"
"django_blog_it",
]

MIDDLEWARE = [
Expand Down
Loading

0 comments on commit d0e6e2b

Please sign in to comment.