Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1530: fix deprecation warning - config_entry set in base class #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

folfy
Copy link
Collaborator

@folfy folfy commented Jan 9, 2025

Seems to be already handled in base-base class, see https://developers.home-assistant.io/blog/2024/11/12/options-flow/
(not in https://github.com/home-assistant/core/blob/dev/homeassistant/config_entries.py#L3169 - this is also deprecated/not needed anymore)

Changes:

Fixed override of init properly calling the base-class with super(), which also means the related lines here are now redundant and can be removed.

Related issue (check one):

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version: 2024.12
Zigbee2MQTT Version: N/A (ZHA)
TRV Hardware:

@folfy folfy force-pushed the bugfix/optionflow branch from ece87d0 to ad27a85 Compare January 9, 2025 20:57
@folfy folfy force-pushed the bugfix/optionflow branch from ad27a85 to dcefe63 Compare January 9, 2025 21:00
@folfy folfy marked this pull request as ready for review January 9, 2025 21:01
@folfy
Copy link
Collaborator Author

folfy commented Jan 9, 2025

Fixed call to base class initializer (no parameter required), tested on development instance
Actually the parameter from our OptionsFlowHandler init might not be needed anymore either? But it doesn't hurt being there for now.

@folfy folfy changed the title #1530: fix deprecation warning - config_entry should be set in base class #1530: fix deprecation warning - config_entry set in base class Jan 9, 2025
@folfy
Copy link
Collaborator Author

folfy commented Jan 14, 2025

#1530 (comment)

Update min. version to 2024.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting option flow config_entry is deprecated (HA 2025.12)
1 participant