Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Gymnasium #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ItaiBear
Copy link

Description

Switched from gym to gymnasium, and updated all relevant code and unit tests.
Relies on Kautenja/nes-py#94
Also commented out a group of unit tests of the registration as they are irrelevant since ~2019, when access to attributes starting with an underscore was prohibited.

Type of change

Please select all relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • MGMT (non-breaking change to deployment, CI, etc.
  • Breaking changes, because of new Gymnasium API.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

ItaiBear added 2 commits July 18, 2023 02:26
relies on Kautenja/nes-py#94
also commented out a group of unit tests on the registration as they are irrelevant since ~2019, when access to attributes starting with an underscore was prohibited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant