-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local git uri support for userPlugins and the abbility for userPlugins to specify their own derivation #40
base: main
Are you sure you want to change the base?
Conversation
fixes #39 |
I am having issues with the plugin being properly imported, maybe this is specific to the local git uri, further testing is needed. |
Sorry I've been busy for the past few days, Ill be able to look this over and maybe write some code for it in a couple days from now |
The original code for the plugins was taken from a user flake I found, so I don't fully understand how it works |
@KaylorBen I am developing a vencord plugin as I mentioned, I am dealing alot with dynamic imports and bundlers, so I see fit to include the abbility for userplugins to specify their own derivation, which is optional, also I would like to address this in the same PR as git uri support and userplugin derivation are already quite intertwined in my PR. What do you think of this? At the very least, a setting to enable this abbility for userplugin derviations. |
Testing this now, thanks for putting a lot of work into it, and sorry I haven't looked that deep into it. Should be fine to merge if it doesn't cause any issues. |
The git branch is polluted, I had issues with local testing so I had to push all my changes to a testing branch, I don't know why it is merging the wrong histories (or appearing so). Aside from that, I made it more modular, I added the git uri and path functionality, and the ability for userplugins to specify their own derivation, and I understand most of the code which had no documentation. I plan to: Some of these changes arnt things I done which confuses me, like hash changes. After a bit of more work then it'll be OK to merge. |
I pulled it and it builds my config correctly w/t custom plugins and such, so just a matter of removing testing stuff and traces and it should be good I think. |
140e6ee
to
181cc46
Compare
…ded the abbilities for plugins to be built as derivations" added testing for coerceGit Revert 'package update' added the abbility to specify a local git repo successfully and without error, note: will need to clean up comments after testing Added userplugin custom derviation support Making sure userplugins is evaluated Undoing inherit ensure that a local path works added vencordPkgs as a input added debugging Re-added testing on new branch Changed defaultVencord to vencordPkgs (as I changed it in my testing) Fixed rebase mishap Removed some traces
181cc46
to
717c9fb
Compare
Hey, @KaylorBen, Can you have a look at this please? |
The changes disappeared because of the previous merge for some reason
This PR has 108 commits. Could you please rebase and only keep the relevant commits for the PR? |
Yeah sorry, some rebase mishap caused the repository current comits to be treated as my commits, my changes are like 3, I'll fix it. |
@SpiderUnderUrBed Could you share some user plugins? I'd like to test your PR, but since I don't use any third-party plugins, I can't really test it Also, please run |
I need help rebasing the PR, once the PR is rebased, I will then share some user plugins and format it, then also add more documentation, the only commits I need to keep are the recent ones made solely by me, you can pick up which ones by comparing it to the repo commit history. Also could you share the steps you took to fix it please, so I know how to fix such a issue in the future. |
Okay, so it looks like we've got just one commit that actually matters: Since your current branch is kinda messy, let's just redo it (the branch) from Here's the plan:
Now you've got a clean main with just the stuff you need. You said that you
When you're finally done, just force push it with |
This might not be fully finished, nor fully tested, I moved everything like regex to the top and separated github and git pattern matching, I removed coercion and instead did mapping later and used types.oneOf to choose from one of several pattern types such as package, path, git, GitHub.
TODO:
Right now I am not utilizing the rev I get from git, which I can use for version pinning.
I am open for suggestions on how to improve this.