Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16 Add Pipfile and lock #17

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

Createdd
Copy link
Member

@Createdd Createdd commented Aug 15, 2018

To make the starting with pipenv possible
close #16
close #10

@Createdd Createdd added enhancement 🚀 New feature or request improve open source 👐 Improve the open source character labels Aug 15, 2018
@Createdd Createdd self-assigned this Aug 15, 2018
@Createdd Createdd requested a review from liadmagen August 15, 2018 10:24
"flake8" = "*"
ujson = "*"
flask = "*"
flask-Script = "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove flask-script and use native flask (flask run) instead....

Copy link
Member Author

@Createdd Createdd Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I created a separate issue for that (#14 ) but right now this would break the start of the app :)

@Createdd Createdd merged commit 26d08a6 into master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request improve open source 👐 Improve the open source character
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requirements and implement proper Pipfile Add pipenv in addition to conda and pip
2 participants