Fix Blink rendering due to broken CSS #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We (well, Walt [1]) discover an issue with Chrome rendering oddly in our Labeling project.
Turn out this affects any Blink based browser (Edge, Brave) - and one of the CSS style sheet
`dm/css/main.css` was not applied. This does not affect Firefox or Safari, which use different
rendering engine.
We have not deployed anything to Label Studio for the last 3 weeks.
Digging in a bit, it turns out that only "some" of the style from `dm/css/main.css` is not applied.
Binary searching the style, this is the culprit line:
```
// works
.dm-grid-view__cell {
box-sizing: border-box;
padding: 16px 16px 0 0
}
// invalid!
.dm-grid-view__cell:nth-child(var(--column-count)) {
padding-right: 0
}
// fail
.dm-grid-view__cell-header {
background: #f9f9f9;
display: flex;
justify-content: space-betwee;
padding: 5px;
width: 100%
}
```
Removing that CSS selector seems to have fix the rendering issue!
From this, it is easy to reference the main branch issue. Here is the main Label
Studio fix, which reference a break that happens 2 weeks ago:
* issues (fixed in 1.13): HumanSignal#6256
* fix commit: HumanSignal@cb6e4c3
NOTE: that this is part of the `data manager` setup which will not be overwritten by
our front-end deploy (this is a seperate package).
Issue: https://khanacademy.atlassian.net/browse/DI-1565
Test Plan:
Deploy on test and see rendering is fixed.
dat-boris
force-pushed
the
fix-blink
branch
from
384e9db to
c9f48cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We (well, Walt) discovered an issue with Chrome rendering oddly in our Labeling project.
Turn out this affects any Blink rendered browser (Edge, Brave) - and one of the CSS style sheet
dm/css/main.csswas not applied. This does not affect Firefox or Safari, which use differentrendering engine.
We have not deployed anything to Label Studio for the last 3 weeks.
Digging in a bit, it turns out that only "some" of the style from
dm/css/main.cssis not applied.Binary searching the style, this is the culprit line:
Removing that CSS selector seems to have fix the rendering issue - CSS variable cannot be used in sub selector
and this breaks (only) blink renderer.
From this, it is easy to reference the main branch issue. Here is the main Label
Studio fix, which reference a break that happens 2 weeks ago:
NOTE: that this is part of the
data managersetup which will not be overwritten byour front-end deploy (this is a separate package).
Issue: https://khanacademy.atlassian.net/browse/DI-1565
Test Plan
Deploy on test and see rendering is fixed.
(see test project, screenshot ommited since this is an open repo)