Skip to content

Commit

Permalink
Changesets: Bump form package to test release process (#2410)
Browse files Browse the repository at this point in the history
## Summary:

This PR is meant to bump the version of the form package to test changesets.

We are seeing if a change being applied in #2409 will fix the issue we are
seeing with changesets not being triggering PR checks at all.

This is causing that packages are not being published to NPM.

Issue: XXX-XXXX

## Test plan:

Land this PR and see if the changesets checks are triggered once the Release PR
is created.

Author: jandrade

Reviewers: beaesguerra, jeremywiebe

Required Reviewers:

Approved By: beaesguerra

Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️  Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️  dependabot

Pull Request URL: #2410
  • Loading branch information
jandrade authored Dec 20, 2024
1 parent 1aa4fef commit 53b4197
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/young-pumpkins-compete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/wonder-blocks-form": patch
---

Adding more info about the legend change
1 change: 1 addition & 0 deletions packages/wonder-blocks-form/src/components/group-styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const styles: StyleDeclaration = StyleSheet.create({
legend: {
padding: 0,
// Let the legend use the size defined by the parent.
// NOTE: This applies to `RadioGroup` and `CheckboxGroup`.
width: "100%",
},

Expand Down

0 comments on commit 53b4197

Please sign in to comment.