Remove references to __FILE__ #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses of __FILE__ leak the directory structure of the machine used to build because it adds a string to the string table with the full path name. Since the existing uses were not really needed, I am simply removing all of them. Fixes KhronosGroup#5416
SPIRV_ASSERT is used, and it only uses `__FILE__` in the debug build, so it should not be a problem.
cassiebeckley
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses of
__FILE__leak the directory structure of the machine used tobuild because it adds a string to the string table with the full path
name. Since the existing uses were not really needed, I am simply
removing all of them.
Fixes #5416