opt: add StorageImageReadWithoutFormat to cap trim #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StorageImageReadWithoutFormat capability is only required when an image type with the format set to Unknown is used with some specific OpImageRead or OpImageSparseRead instructions. This patch adds the required code to the capability trimming pass to remove the StorageImageReadWithoutFormat capability when not required. Signed-off-by: Nathan Gauër <[email protected]>
cassiebeckley
approved these changes
Nov 13, 2023
s-perron
approved these changes
Nov 14, 2023
sajjadmirzanv
pushed a commit
to sajjadmirzanv/SPIRV-Tools
that referenced
this pull request
Nov 15, 2023
The StorageImageReadWithoutFormat capability is only required when an image type with the format set to Unknown is used with some specific OpImageRead or OpImageSparseRead instructions. This patch adds the required code to the capability trimming pass to remove the StorageImageReadWithoutFormat capability when not required. Signed-off-by: Nathan Gauër <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StorageImageReadWithoutFormat capability is only required when an image type with the format set to Unknown is used with some specific OpImageRead or OpImageSparseRead instructions.
This patch adds the required code to the capability trimming pass to remove the StorageImageReadWithoutFormat capability when not required.
This would fix microsoft/DirectXShaderCompiler#5906 once merged in DXC.