Disable Wnonnull in BUILD.gn #5487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue in the latest Android NDK where the `std::system` is flagged as having a non-null parameter. This behaviour is currently used by spirv-reduce and spirv-fuzz (and is documented as being allowed). In order to allow building with the latest NDK disable the `Wnonnull` warning in the BUILD.gn file.
|
Confirmed the pull request fixes the compile with NDK r26b. |
dneto0
approved these changes
Nov 28, 2023
|
Note: According to android/ndk#1976, the annotation is intentional, so this work-around will need to be permanent (or the code updated). |
|
I have also filed #5494 to remove the usages. |
|
Suggest closing, as #5494 has landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the latest Android NDK where the
std::systemis flagged as having a non-null parameter. This behaviour is currently used by spirv-reduce and spirv-fuzz (and is documented as being allowed).In order to allow building with the latest NDK disable the
Wnonnullwarning in the BUILD.gn file.