opt: keep all OpSource instructions #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveUrquhart
force-pushed
the
keep-all-opsource
branch
2 times, most recently
from
5b535fa to
46b4428
Compare
|
@s-perron, I don't seem to be able to request review? Or I can't find it in the interface. |
Keenuts
approved these changes
Dec 10, 2024
|
This should unblock the pending CI |
SteveUrquhart
force-pushed
the
keep-all-opsource
branch
from
46b4428 to
893de33
Compare
|
@Keenuts, sorry but I wasn't aware of check_code_format.sh previously, and I need the kokoro:run label to be reapplied. |
|
No worries! unblocking CI, will merge if green 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops the optimizer from removing OpSource instructions. If an OpSource contains solely preprocessor instructions, it was being eliminated. Debuggers cannot recompile shaders unless all OpSource instructions are present.