Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax DebugLine validation #5916

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Relax DebugLine validation #5916

merged 1 commit into from
Dec 12, 2024

Conversation

alan-baker
Copy link
Contributor

  • In NonSemantic.Shader.DebugInfo.100, DebugLine validation should only check column end >= column start if line start == line end

See KhronosGroup/SPIRV-Registry#302

cc @spencer-lunarg

@alan-baker
Relax DebugLine validation
cbca401 
* In NonSemantic.Shader.DebugInfo.100, DebugLine validation should only
  check column end >= column start if line start == line end
@alan-baker alan-baker requested a review from dneto0 December 12, 2024 19:23
@dneto0 dneto0 enabled auto-merge (squash) December 12, 2024 19:29
@dneto0 dneto0 merged commit 13b59bf into KhronosGroup:main Dec 12, 2024
22 checks passed
@dneto0 dneto0 added asan:leak resource leak found by ASAN and removed asan:leak resource leak found by ASAN labels Dec 12, 2024
@alan-baker alan-baker deleted the debug-line-val branch December 12, 2024 20:11
@spencer-lunarg
Copy link
Contributor

awww, good catch, thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-baker @spencer-lunarg @dneto0