Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SPV_INTEL_subgroup_matrix_multiply_accumulate #5928

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Jan 7, 2025

see: KhronosGroup/SPIRV-Registry#306

This will need to remain a draft until the header changes are merged, at which time I'll add another commit to update the DEPS file: KhronosGroup/SPIRV-Headers#471.

@bashbaug bashbaug marked this pull request as draft January 7, 2025 23:38
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, once the headers are merged and the DEPS are updated ping this PR and I'll make sure the bots run.

@alan-baker
Copy link
Contributor

@bashbaug can you update the deps for this and make it a non-draft?

@s-perron
Copy link
Collaborator

s-perron commented Jan 16, 2025

I believe DEPS has already been updated: #5943.

No it is still 1 commit behind.

@alan-baker alan-baker marked this pull request as ready for review January 16, 2025 18:41
@alan-baker
Copy link
Contributor

@bashbaug can you update the deps for this and make it a non-draft?

I can push to your branch, so I updated the deps.

@bashbaug
Copy link
Contributor Author

Thanks, you beat me to it. :)

@alan-baker alan-baker merged commit f942f65 into KhronosGroup:main Jan 16, 2025
22 checks passed
@bashbaug bashbaug deleted the SPV_INTEL_subgroup_matrix_multiply_accumulate branch January 16, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants