Add/Run/CI Clang-format on adoc/code #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TApplencourt
changed the title
TApplencourt
force-pushed
the
clang-ci
branch
7 times, most recently
from
78c8619 to
0f59af1
Compare
TApplencourt
force-pushed
the
clang-ci
branch
from
0f59af1 to
a3085ee
Compare
TApplencourt
changed the title
|
Ready to review |
gmlueck
approved these changes
Jan 31, 2025
keryell
reviewed
Feb 6, 2025
| ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ] | ||
| SpaceBeforeParens: ControlStatements | ||
| DisableFormat: false | ||
| SortIncludes: true |
There was a problem hiding this comment.
Why repeating all the definitions used by default in the Google style?
Could you just keep the one which differ so we can understand the changes to the basic style?
I doubt we have ObjectiveC language constructs, so ObjCSpaceBeforeProtocolList and others seem useless. 😄
There was a problem hiding this comment.
Fixed with 1a32f1
|
Ready to merge now, editorial. |
|
Merging as editorial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format formatused by the CTS../adoc/codefiles./adoc/codeare incorrectly formatted.We can use this PR to see if we like this
format-styleor want to customize it.Then, I can do another PR to do the same thing on all the other
codeblocks.