Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definition of marray::size() #716

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix definition of marray::size() #716

merged 1 commit into from
Feb 13, 2025

Conversation

Pennycook
Copy link
Contributor

This should return the number of elements in the marray, not its size in bytes.

Closes #525.

@Pennycook
Fix definition of marray::size()
f9bfada 
This should return the number of elements in the marray, not its size in bytes.
@Pennycook Pennycook added the bug Something isn't working label Feb 12, 2025
@sycl-issue-bot sycl-issue-bot bot mentioned this pull request Feb 12, 2025
Closed
@TApplencourt
Copy link
Contributor

\o/

gmlueck
gmlueck approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Good catch.

I verified that DPC++ already implements this as "number of elements" and not "size in bytes". Also, it looks like the CTS is testing it that way also. Therefore, I think this is what we meant all along.

@tomdeakin
Copy link
Contributor

WG approved to merge

@gmlueck gmlueck merged commit 7499fc7 into KhronosGroup:main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdeakin tomdeakin tomdeakin approved these changes

@gmlueck gmlueck gmlueck approved these changes

@TApplencourt TApplencourt TApplencourt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the definition of marray::size() to return NumElements
4 participants
@Pennycook @TApplencourt @tomdeakin @gmlueck