Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "inverse sqrt" with "reciprocal" sqrt #717

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Pennycook
Copy link
Contributor

The "inverse" of sqrt is x*x. Referring to "reciprocal" sqrt is more accurate.

Closes #655.

The "inverse" of sqrt is x*x. Referring to "reciprocal" sqrt is more accurate.
@Pennycook Pennycook added the editorial Some purely editorial problem label Feb 12, 2025
@Pennycook Pennycook requested a review from gmlueck February 12, 2025 15:43
@TApplencourt
Copy link
Contributor

Agree, and it's even in the name of the function rsqrt :)

Copy link
Contributor

@tomdeakin tomdeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer wording for 1/sqrt(x).
Probably just worth a quick check by WG that we do mean this and not inverse.

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK because the name of the function is "rsqrt" (not "isqrt"). However:

  • OpenCL names this function "inverse square root".
  • I think the term "inverse square root" is commonly used. For example, see this Wikipedia article.
  • According to Google search "inverse square root" is about 5 times more commonly used than "reciprocal square root".

I checked the wording in IEEE 754 to see what they call this function, but they do not use any English description. They just name the function "rsqrt".

@tomdeakin
Copy link
Contributor

WG approved to merge.

@gmlueck gmlueck merged commit 768e913 into KhronosGroup:main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Some purely editorial problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Inverse square root" should be "reciprocal square root"
4 participants