Clarify group algorithms don't support iterators #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The working group decided that SYCL 2020 should be limited to pointers. Extending these interfaces to accept iterators is under consideration for SYCL-Next.
TApplencourt
approved these changes
Feb 13, 2025
gmlueck
reviewed
Feb 13, 2025
| @@ -21703,7 +21703,7 @@ reported by [code]#Group::fence_scope#). | |||
| SYCL provides an algorithms library based on the functions described in Section | |||
| 28 of the {cpp17} specification. | |||
| The first argument to each function is a <<group>>, and data ranges can be | |||
| described using pointers, iterators or instances of the [code]#multi_ptr# class. | |||
| described using pointers or instances of the [code]#multi_ptr# class. | |||
There was a problem hiding this comment.
Maybe this is a separate PR, but the constraints on the functions below don't make it clear that multi_ptr is allowed. They just say "Ptr is a pointer".
There was a problem hiding this comment.
I'd prefer to do it in a separate PR, if you don't mind. It probably makes sense to fix the Ptr constraints while addressing #340, because we're already going to have to clarify what they can point to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The working group decided that SYCL 2020 should be limited to pointers. Extending these interfaces to accept iterators is under consideration for SYCL-Next.
Closes #409.