Add integral overloads for id and range operators
#726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification previously only listed an overload for size_t. However, all existing SYCL implementations provide overloads for all integral types to avoid ambiguity in operator overloads. This change aligns the specification with the behavior of existing SYCL implementations.
Previously, the synopses for these classes listed operators in this order: - +(id, T) - +=(id, T) - +(T, id) This made it very easy to miss that + was defined with id as both the lhs and rhs. To improve readability, this commit changes the order to: - +(id, T) - +(T, id) - +=(id, T)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification previously only listed an overload for
size_t. However, all existing SYCL implementations provide overloads forall integral types to avoid ambiguity in operator overloads.
This change aligns the specification with the behavior of existing SYCL implementations.
Closes #539, closes #711.
Note that I also re-ordered the synopses for
idandrangebased on an observation made during discussion in #711. It might be easier to review the changes from the two commits separately: the first commit adjusts the overloads, and the second commit reorders things.