android: Update SPIRV-Tools #7050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 92035. |
|
CI Vulkan-ValidationLayers build queued with queue ID 92044. |
SPIRV-Tools no longer links against android libraries it doesn't use. See KhronosGroup/SPIRV-Tools#5482 Now VVL must explicitly link against `android`
|
CI Vulkan-ValidationLayers build queued with queue ID 92056. |
juan-lunarg
referenced
this pull request
in KhronosGroup/SPIRV-Tools
Nov 29, 2023
* cmake: Simplify usage of option boolean OFF is the default value: https://cmake.org/cmake/help/latest/command/option.html * Fix iOS / Android CMake builds closes #4437
|
CI Vulkan-ValidationLayers build # 14701 running. |
|
Seeing some new test failures. Out of scope for what I originally intended this PR to be. Just keep in mind this Android change for when we do update SPIRV-Tools. |
jeremyg-lunarg
added a commit
to jeremyg-lunarg/Vulkan-ValidationLayers
that referenced
this pull request
Dec 4, 2023
Remove stage specific debug info that is only needed by GPU-AV. This allows debug printfs to be used in multi stage shader modules. Requires KhronosGroup/SPIRV-Tools#5495 Fixes KhronosGroup#4350 Also includes the VUL linking change from KhronosGroup#7050
jeremyg-lunarg
added a commit
that referenced
this pull request
Dec 5, 2023
Remove stage specific debug info that is only needed by GPU-AV. This allows debug printfs to be used in multi stage shader modules. Requires KhronosGroup/SPIRV-Tools#5495 Fixes #4350 Also includes the VUL linking change from #7050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRV-Tools no longer links against android libraries it doesn't use. See KhronosGroup/SPIRV-Tools#5482
Now VVL must explicitly link against
android