Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Improve factories #792

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Nov 4, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #791

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson self-assigned this Nov 4, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.30 milestone Nov 4, 2023
@CalvinWilkinson CalvinWilkinson changed the title factories 🚧Improve factories Nov 4, 2023
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction preview Done while in preview 🧨breaking-changes Feature/changes contains breaking changes labels Nov 4, 2023
@CalvinWilkinson CalvinWilkinson added the ✨new-feature New feature that does not exist label Nov 4, 2023
@CalvinWilkinson
Copy link
Member Author

Note
Added https://github.com/KinsonDigital/Velaptor/labels/%E2%9C%A8new%20feature 's
Added the following extension methods to the content loaders:

  • ILoader<ITexture>.Unload(ITexture?)
  • ILoader<IFont>.Unload(IFont?)
  • ILoader<ISound>.Unload(ISound?)
  • ILoader<IAtlasData>.Unload(IAtlasData?)

@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented Nov 4, 2023

*Warning
Introduced the following https://github.com/KinsonDigital/Velaptor/labels/%F0%9F%A7%A8breaking%20changes

  1. Removed ContentExtensions.Load(this FontLoader) extension method.
  2. Removed the IContentLoader interface.
  3. Removed the ContentLoader class.
  4. Removed the ContentLoader property from the Window class.
  5. Removed the ContentLoader property from the IWindow interface.
  6. Removed the ContentLoader property from the IScene interface.
  7. Removed the ContentLoader property from the SceneBase class.
  8. Removed the CreateContentLoader method from the ContentLoaderFactory static class.
  9. Converted the RendererFactory to a static class to follow the same pattern as ContentLoaderFactory
  10. Removed the IRendererFactory interface.

@CalvinWilkinson CalvinWilkinson force-pushed the feature/791-improve-factories branch from 401f66f to 7f60a47 Compare November 4, 2023 17:11
@CalvinWilkinson CalvinWilkinson added the on-hold On Hold (Cannot Move Foward) label Nov 4, 2023
@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review November 6, 2023 14:26
@CalvinWilkinson CalvinWilkinson merged commit 37876ba into preview Nov 6, 2023
15 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/791-improve-factories branch November 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes ✨new-feature New feature that does not exist on-hold On Hold (Cannot Move Foward) preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Improve factories
2 participants